Skip to content

Qualcomm AI Engine Direct - Lift scalar arguments #8642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

chunit-quic
Copy link
Collaborator

@chunit-quic chunit-quic commented Feb 24, 2025

  • Add pass to lift before quantizer quantize
  • Add preprocess function for fp model
  • Delete annotate and quant scalar pass
  • Delete binary with scalar pass
  • Delete codeblocks of op builder for scalar
  • Mark CI expected failure cases

cc @cccclai @winskuo-quic @shewu-quic @cbilgin

- Add pass to lift before quantizer quantize
- Add preprocess function for fp model
- Delete annotate and quant scalar pass
- Delete binary with scalar pass
- Delete codeblocks of op builder for scalar
- Mark CI expected failure cases
@chunit-quic chunit-quic requested a review from cccclai as a code owner February 24, 2025 02:16
Copy link

pytorch-bot bot commented Feb 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8642

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8443ebd with merge base 30d4cc8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2025
@chunit-quic
Copy link
Collaborator Author

Hi @cccclai,

This is the pass followed by PR8313. We trimed codes and make scalar be lifted. Thank you. :)

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Feb 26, 2025

This PR also needs to rebase...

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a lot more simpler, thank you!

@cccclai cccclai added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm topic: not user facing labels Feb 26, 2025
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 80fcb41 into pytorch:main Feb 28, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants