[ET-VK] Moving PushConstantData class implementation a separate h and cpp file. #8648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cpp file. This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8648
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6a700b1 with merge base e673f7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70102031 |
…arate h and cpp file." This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70102031 |
…arate h and cpp file." This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70102031 |
SS-JIA
approved these changes
Mar 6, 2025
…arate h and cpp file." This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70102031 |
…arate h and cpp file." This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70102031 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Mar 8, 2025
… cpp file. (#9047) Pull Request resolved: #8648 This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. ghstack-source-id: 270375637 @exported-using-ghexport Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) Co-authored-by: Vivek Trivedi <[email protected]>
trivedivivek
added a commit
that referenced
this pull request
Mar 8, 2025
* [ET-VK] Moving PushConstantData class implementation a separate h and cpp file. Pull Request resolved: #8648 This diff moves the implementation of the `PushConstantData` class from the `DispatchNode` file to a separate `PushConstantData.h` and `PushConstantData.cpp` files. This is done to enable push constants for PrepackNodes in follow up changes. ghstack-source-id: 270375637 @exported-using-ghexport Differential Revision: [D70102031](https://our.internmc.facebook.com/intern/diff/D70102031/) * [ET-VK] Adding PushConstantDataInfo input to PrepackNode class. Pull Request resolved: #8649 This diff adds a new input to the PrepackNode class called PushConstantDataInfo. This input is used to pass push constant data to the shader. ghstack-source-id: 270375636 @exported-using-ghexport Differential Revision: [D70102043](https://our.internmc.facebook.com/intern/diff/D70102043/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff moves the implementation of the
PushConstantDataclass from theDispatchNodefile to a separatePushConstantData.handPushConstantData.cppfiles. This is done to enable push constants for PrepackNodes in follow up changes.Differential Revision: D70102031