Skip to content

Qualcomm AI Engine Direct - Remove copy headers mechanism #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DannyYuyang-quic
Copy link
Collaborator

Summary

  • Remove redundant directory

Test plan

Build QNN backend

@facebook-github-bot
Copy link
Contributor

Hi @DannyYuyang-quic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

pytorch-bot bot commented Feb 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8678

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a2660bc with merge base 542480c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/Cmake_refactor_qnn_header branch from 969c9bd to 63a9c18 Compare February 25, 2025 09:14
@DannyYuyang-quic DannyYuyang-quic changed the title Qualcomm AI Engine Direct - Replace copy headers mechanism Qualcomm AI Engine Direct - Remove copy headers mechanism Feb 25, 2025
@cccclai
Copy link
Contributor

cccclai commented Feb 26, 2025

The CLA is still not there yet :/ though I like this change

@DannyYuyang-quic
Copy link
Collaborator Author

Thanks for keeping up with the CLA progress.
I’ll have someone from my team submit the PR on my behalf. Thanks!

@haowhsu-quic haowhsu-quic force-pushed the dev1/danny/Cmake_refactor_qnn_header branch from 63a9c18 to a2660bc Compare March 3, 2025 09:50
@haowhsu-quic
Copy link
Collaborator

@pytorchbot label "release notes: qualcomm"

@haowhsu-quic
Copy link
Collaborator

Replace this with #8877.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@cccclai
Copy link
Contributor

cccclai commented Apr 7, 2025

Replace this with #8877.

Will close this PR and in favor of the new one.

@cccclai cccclai closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants