Skip to content

[Android] Rename build script #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[Android] Rename build script #8747

merged 1 commit into from
Feb 26, 2025

Conversation

kirklandsign
Copy link
Contributor

Summary

build_android_llm_demo.sh -> build_android_library.sh
It's not only for LLM demo, but for general use case as well

Test plan

CI

Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 8 Pending

As of commit f6c75be with merge base 50fb8a9 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
It's not only for LLM demo, but for general use case as well
@GregoryComer
Copy link
Member

GregoryComer commented Feb 26, 2025

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

@kirklandsign kirklandsign added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 26, 2025
@kirklandsign
Copy link
Contributor Author

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

Thank you. Mind sharing the PR or issue number so we can remind ourself later?

@GregoryComer
Copy link
Member

Thanks! We'll also probably want to document usage under using-executorch-android.md and using-executorch-building-from-source as a follow-up.

Thank you. Mind sharing the PR or issue number so we can remind ourself later?

Sure. We can track in #8261.

@kirklandsign kirklandsign merged commit afcec1d into main Feb 26, 2025
56 of 58 checks passed
@kirklandsign kirklandsign deleted the rename-script branch February 26, 2025 23:15
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results February 26, 2025 23:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants