[build] Add editable mode unittest #8817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
Merged
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8817
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 7 PendingAs of commit f5df1b3 with merge base 76fb844 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 3b91bfdd3fc950fc731fafadd0f0d0ca37865c79 Pull Request resolved: #8817
facebook-github-bot
added
the
CLA Signed
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: d8c8aa5f61af99f258b376780f135b7a0eb3ced1 Pull Request resolved: #8817
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 4e3c46715f49171702767c33e7f0e9faedb27144 Pull Request resolved: #8817
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 2f5bc65bb49efc9855887ba3cf14e4e20bb5138f Pull Request resolved: #8817
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
|
Thanks for adding this test, looks like a good change, let's fix CI tho. |
swolchok
approved these changes
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: d3c3d8e90d8bbc4b1088028627c2e532cb683f35 Pull Request resolved: #8817
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 94fad2313ad52eda0c8d413c798894d4c468d1d0 Pull Request resolved: #8817
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: a297ee14fb788418c61a45fbb42f7567141eefee Pull Request resolved: #8817
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
larryliu0820
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 4e4360b564c83f12ad6c5f8def78993e0ded8cc9 Pull Request resolved: #8817
larryliu0820
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
larryliu0820
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: ea9080503c6738558e3626f079338880d702c9b2 Pull Request resolved: #8817
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 015cf344d53138da5a50c307dc70c925f0542539 Pull Request resolved: #8817
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: f59485c03fbb4849d851cc70ba98a20c99b6921a Pull Request resolved: #8817
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Feb 28, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 19ab82778b4883ac986ef62c8d0aa87189e7c16e Pull Request resolved: #8817
larryliu0820
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
larryliu0820
merged commit c4de36a
into
gh/larryliu0820/62/base
105 of 106 checks passed
larryliu0820
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
larryliu0820
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
larryliu0820
added a commit
that referenced
this pull request
Mar 1, 2025
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. ghstack-source-id: 19ab82778b4883ac986ef62c8d0aa87189e7c16e Pull Request resolved: #8817 Co-authored-by: Mengwei Liu <[email protected]>
Merged
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 19, 2025
Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820
mergennachin
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 20, 2025
Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820 (cherry picked from commit bc86b6c)
svekars
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 21, 2025
Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820
ZainRizvi
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 25, 2025
Update ExecuTorch pin update (#149539) Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to #144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: #149539 Approved by: https://github.com/larryliu0820 (cherry picked from commit bc86b6c)
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Latest commit in https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50 Follow-up to pytorch#144480 (comment) Also, need to incorporate change from pytorch/executorch#8817 Test Plan: Monitor linux-jammy-py3-clang12-executorch test Pull Request resolved: pytorch#149539 Approved by: https://github.com/larryliu0820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As titled. To do this we need to refactor the arguments being passed
into
setup-linux.shsetup-macos.shandunittest-linux.shunittest-macos.sh.