Skip to content

Basic performance logging for Llama python runner #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

jackzhxng
Copy link
Contributor

No description provided.

@jackzhxng jackzhxng requested a review from lucylq as a code owner March 1, 2025 01:12
Copy link

pytorch-bot bot commented Mar 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8862

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6974b76 with merge base 01c2f36 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2025
@jackzhxng jackzhxng force-pushed the jz/native-runner-perf branch from 051416c to 54cf389 Compare March 1, 2025 01:13
@jackzhxng jackzhxng added topic: not user facing release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava and removed topic: not user facing labels Mar 1, 2025
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! What are you trying to log times for btw?

@jackzhxng
Copy link
Contributor Author

@lucylq models like Qwen and Phi which we don't have json tokenizer cpp support for yet :'|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants