Don't partition per_tensor weights with qd8 (#8787) #8890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8890
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc1a8b0 with merge base 9aca1fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: pytorch#8787 This is not supported, so we shouldn't partition it. Add an expectedFailure test to indicate that this is not supported. ghstack-source-id: 269356867 exported-using-ghexport Reviewed By: mcr229 Differential Revision: D70343584
|
This pull request was exported from Phabricator. Differential Revision: D70343584 |
|
This pull request was exported from Phabricator. Differential Revision: D70343584 |
digantdesai
force-pushed
the
export-D70343584
branch
from
af15b91 to
bc1a8b0
Compare
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is not supported, so we shouldn't partition it.
Add an expectedFailure test to indicate that this is not supported.
ghstack-source-id: 269356867
exported-using-ghexport
Reviewed By: mcr229
Differential Revision: D70343584