Skip to content

Add cpu_thread setting logic to xnn_executor_runner #8902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Mar 4, 2025
Merged

Add cpu_thread setting logic to xnn_executor_runner #8902

merged 30 commits into from
Mar 4, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 3, 2025 •
edited
Loading

No description provided.

@swolchok
Update
f1ace77 
[ghstack-poisoned]
@swolchok
Update
d3a0f67 
[ghstack-poisoned]
@swolchok
Update
a78277d 
[ghstack-poisoned]
@swolchok
Update
6b6180c 
[ghstack-poisoned]
@swolchok
Update
7cbe7a1 
[ghstack-poisoned]
@swolchok
Update
8e8ce33 
[ghstack-poisoned]
@swolchok
Update
093a6d3 
[ghstack-poisoned]
@swolchok
Update
77f039c 
[ghstack-poisoned]
@swolchok
Update
c4e4541 
[ghstack-poisoned]
@swolchok
Update
18583c3 
[ghstack-poisoned]
@swolchok
Update
947e320 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8902

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ddabcf7 with merge base 09ad20a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Mar 3, 2025
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
This was referenced Mar 3, 2025
Closed
Closed
Closed
Merged
swolchok added a commit that referenced this pull request Mar 3, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner
e87af4c 
ghstack-source-id: f1452c802d39347ab465bc8fdf285814cb5deead
ghstack-comment-id: 2695791073
Pull Request resolved: #8902
swolchok added 4 commits March 3, 2025 15:31
@swolchok
Update
d3edbcb 
[ghstack-poisoned]
@swolchok
Update
bf96b84 
[ghstack-poisoned]
@swolchok
Update
fe126ae 
[ghstack-poisoned]
@swolchok
Update
6bd66f1 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 3, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner
fd91829 
ghstack-source-id: ed242587652dfe1361a492bff2c6f1291616f799
ghstack-comment-id: 2695791073
Pull Request resolved: #8902
@swolchok
Update
a93cd69 
[ghstack-poisoned]
iseeyuan
iseeyuan approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

swolchok added 10 commits March 4, 2025 08:11
@swolchok
Update
764977b 
[ghstack-poisoned]
@swolchok
Update
c7d57ee 
[ghstack-poisoned]
@swolchok
Update
fa09b62 
[ghstack-poisoned]
@swolchok
Update
773feea 
[ghstack-poisoned]
@swolchok
Update
58f544f 
[ghstack-poisoned]
@swolchok
Update
fd6a085 
[ghstack-poisoned]
@swolchok
Update
f694589 
[ghstack-poisoned]
@swolchok
Update
3143085 
[ghstack-poisoned]
@swolchok
Update
deb1934 
[ghstack-poisoned]
@swolchok
Update
bd46558 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner
bfff341 
ghstack-source-id: 24891e8d9446f7998310a913106efe09d897a66e
ghstack-comment-id: 2695791073
Pull Request resolved: #8902
swolchok added 2 commits March 4, 2025 09:47
@swolchok
Update
80589b0 
[ghstack-poisoned]
@swolchok
Update
fc4ec44 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner
a4cb378 
ghstack-source-id: f3b5256a73dd45a30a3186c12861331362431657
ghstack-comment-id: 2695791073
Pull Request resolved: #8902
swolchok added 2 commits March 4, 2025 10:00
@swolchok
Update
18c64ad 
[ghstack-poisoned]
@swolchok
Update
ddabcf7 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner
0bc043a 
ghstack-source-id: 99c14ffb3e070c5a1895a78e0f8bb6baaa1609a8
ghstack-comment-id: 2695791073
Pull Request resolved: #8902
mcr229
mcr229 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine, but honestly coming back to this after year+ since our first release, do we need to have an xnn_executor_runner which is separate from the executor_runner? Should our CMake just be if BUILD_XNNPACK=ON, we link XNNPACK to executor_runner, if not then we dont?

Base automatically changed from gh/swolchok/304/head to main March 4, 2025 19:17
@swolchok
Copy link
Contributor Author

swolchok commented Mar 4, 2025

this seems fine, but honestly coming back to this after year+ since our first release, do we need to have an xnn_executor_runner which is separate from the executor_runner? Should our CMake just be if BUILD_XNNPACK=ON, we link XNNPACK to executor_runner, if not then we dont?

sounds like a great idea to me! this change is still an incremental improvement though so I will land it.

On another note, CI is green, rebasing to make sure extra changes from previous commit go away and then merging without waiting for CI to run again

@swolchok swolchok merged commit 6e09ea2 into main Mar 4, 2025
51 checks passed
@swolchok swolchok deleted the gh/swolchok/305/head branch March 4, 2025 21:00
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@swolchok
Add cpu_thread setting logic to xnn_executor_runner (#8902)
5bb91d5
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iseeyuan iseeyuan iseeyuan approved these changes

@mcr229 mcr229 mcr229 approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swolchok @iseeyuan @mcr229 @facebook-github-bot