-
Notifications
You must be signed in to change notification settings - Fork 536
Fix ANE llama export #8904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ANE llama export #8904
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8904
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 83ae7aa with merge base 24671a9 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing the export issue
.github/workflows/pull.yml
Outdated
@@ -495,6 +495,38 @@ jobs: | |||
# Test static llama weight sharing and accuracy | |||
PYTHON_EXECUTABLE=python bash .ci/scripts/test_qnn_static_llama.sh | |||
|
|||
test-static-llama-ane: | |||
name: test-static-llama-ane | |||
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought all the mac jobs are in trunk because of the cost/reliability issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @kirklandsign @huydhn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it true? Maybe just rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #610, not sure if it's still true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, macos_job ideally should be in trunk.yml and can be run on PR using ciflow/trunk
. The job could be here is it's important enough to justify running in every pull requests. I assume that this is not the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I moved the job to trunk.yml
* up * up * up * up * up * up * up * up * up * up * up * up * up
Fixes ANE llama export and adds unit test