[Windows] [Tensor.cpp] add #include <algorithm> #8912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8912
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5d2afa5 with merge base 24671a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
approved these changes
Mar 4, 2025
SS-JIA
added
the
release notes: build
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
[Tensor.cpp] add algorithm include to get stable_sort and iter_swap on windows
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a number of parallel in progress/stale pushes for Windows support. This is the first PR in my attempt, which I will be breaking into small, disparate PRs. I found this necessary for
stable_sortanditer_swapin this file.Test plan
No functional change, verify everything builds.