[Windows] [file_data_loader.cpp] Add compat_unistd.h #8913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamGondelman
requested review from
dbort,
JacobSzwejbka and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8913
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d7cbc98 with merge base 24671a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
approved these changes
Mar 4, 2025
SS-JIA
added
the
release notes: build
|
re: testing, I think CI is sufficient because there should be no change to existing build |
|
@SamGondelman all tests pass which is good. However, there is a lint error; seems you need to remove whitespace at Line 21 of If you want to make managing lints easier, you can set up Then from repo source |
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
* fix windows build issue * revert xnnpack cmakelist and fix file_data_loader * fix lint warning * undo non-relevant changes * linter error - extra newline --------- Co-authored-by: Chao Zhang <[email protected]>
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the second PR in my attempt to get Windows support working. I've pulled the changes to file_data_loader.cpp from #7217 into their own PR and removed the other changes for now.
Test plan
No functional change since we aren't actually building Windows yet, just verify everything builds.