[Windows] [memory_allocator.h] remove ET_TRY macros

[SamGondelman]

Summary

This is the third PR in my attempt to get Windows support working. I hit these static asserts because these macros weren't implemented. Let's remove the macros and just directly allocate the memory everywhere.

Test plan

Verify everything builds + unit tests.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8914

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 29afa5f with merge base 24671a9 ():

CANCELLED JOB - The following job was cancelled. Please retry:

• trunk / test-models-macos (cmake, vit, xnnpack-quantization-delegation, macos-m1-stable, 90) / macos-job (gh)
  ##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[jackzhxng]

The goal is to eventually remove all usages of ET_TRY_ALLOCATE_OR, ET_TRY_ALLOCATE_INSTANCE_OR, and ET_TRY_ALLOCATE_LIST_OR, these exist to retain compatibility with the non mvc compilers while enabling mvc compilation. Since you are hitting these static assertions, I'm guessing that you are using one of these three macros somewhere in your code - that's where you should replace the macro with the recommended memory_allocator method

[facebook-github-bot]

@SamGondelman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.