Arm backend: Add WhyNoPartitionReporter and report rejected nodes#8963
Merged
zingo merged 2 commits intopytorch:mainfrom Mar 20, 2025
Merged
Arm backend: Add WhyNoPartitionReporter and report rejected nodes#8963zingo merged 2 commits intopytorch:mainfrom
zingo merged 2 commits intopytorch:mainfrom
Conversation
Erik-Lundell
requested review from
JacobSzwejbka,
digantdesai,
larryliu0820 and
tarun292
as code owners
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8963
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit 802d148 with merge base 5cd973c ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Erik-Lundell
added
ciflow/trunk
partner: arm
zingo
approved these changes
Mar 6, 2025
mcr229
reviewed
Mar 12, 2025
mcr229
reviewed
Mar 12, 2025
Contributor
mcr229
left a comment
mcr229
left a comment
There was a problem hiding this comment.
In general this looks good to me, and is what i'm hoping our partitioner logging infra can look like moving forward.
Would love to see placeholder tensors reported in the future, but that can be added later i suppose.
Erik-Lundell
force-pushed
the
op_support
branch
from
28f0d98 to
5a5dc87
Compare
With more complex checks for if nodes are supported or not, it can probably be complicated for a user to understand why a ceratin node was rejected from partitioning. The WhyNoPartitionReporter attempts to mitigate this by producing a table with all rejected nodes with a reason for why they were rejected. The reasoning behind using a class rather than log statements is - The table keeps all reject information in the same place. - Uniform formatting. - Only log the first reject report of a node. - Easier to change how and when the output is logged/dumped to file. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I3765a0db4bfe530b34a7c5d48b04faa5d08e51de
Erik-Lundell
force-pushed
the
op_support
branch
from
5a5dc87 to
f3e823e
Compare
Collaborator
|
MacOs fails unrelatred |
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…torch#8963) With more complex checks for if nodes are supported or not, it can probably be complicated for a user to understand why a ceratin node was rejected from partitioning. The WhyNoPartitionReporter attempts to mitigate this by producing a table with all rejected nodes with a reason for why they were rejected. The reasoning behind using a class rather than log statements is - The table keeps all reject information in the same place. - Uniform formatting. - Only log the first reject report of a node. - Easier to change how and when the output is logged/dumped to file. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…torch#8963) With more complex checks for if nodes are supported or not, it can probably be complicated for a user to understand why a ceratin node was rejected from partitioning. The WhyNoPartitionReporter attempts to mitigate this by producing a table with all rejected nodes with a reason for why they were rejected. The reasoning behind using a class rather than log statements is - The table keeps all reject information in the same place. - Uniform formatting. - Only log the first reject report of a node. - Easier to change how and when the output is logged/dumped to file. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With more complex checks for if nodes are supported or not, it can probably be complicated for a user to understand why a ceratin node was rejected from partitioning.
The WhyNoPartitionReporter attempts to mitigate this by producing a table with all rejected nodes with a reason for why they were rejected.
The reasoning behind using a class rather than log statements is
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218