Skip to content

Revert "[Benchmark] fail test if model artifact does not exist" #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Mar 6, 2025

Reverts #8482

The issue is fixed by Fixes #8125, which catch the app error at test level

Copy link

pytorch-bot bot commented Mar 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8985

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job

As of commit 7ea3a88 with merge base 6170804 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@yangw-dev yangw-dev temporarily deployed to upload-benchmark-results March 6, 2025 01:41 — with GitHub Actions Inactive
@yangw-dev yangw-dev had a problem deploying to upload-benchmark-results March 6, 2025 02:04 — with GitHub Actions Failure
@yangw-dev yangw-dev marked this pull request as ready for review March 6, 2025 07:22
@yangw-dev yangw-dev merged commit c2a8912 into main Mar 6, 2025
64 of 71 checks passed
@yangw-dev yangw-dev deleted the revert-8482-failedTestSpec branch March 6, 2025 07:24
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
Revert "[Benchmark] fail test if model artifact does not exist (#8482)"
This reverts commit 24671a9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevX: Improve error reporting for benchmark jobs.
3 participants