Skip to content

Add buck rules in coreml llama transformer #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Add buck rules in coreml llama transformer #9017

merged 1 commit into from
Mar 7, 2025

Conversation

YIWENX14
Copy link
Contributor

@YIWENX14 YIWENX14 commented Mar 6, 2025

Summary: Add buck rules in coreml llama transformer for importing the modules to internal repo.

Differential Revision: D70415647

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9017

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 2b52cd8 with merge base 6d24d4b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

@YIWENX14
Copy link
Contributor Author

YIWENX14 commented Mar 6, 2025

@pytorchbot label "topic: not user facing"

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Mar 6, 2025
@YIWENX14 @facebook-github-bot
Add buck rules in coreml llama transformer (pytorch#9017)
0d37c3d 
Summary:
Pull Request resolved: pytorch#9017

Add buck rules in coreml llama transformer for importing the modules to internal repo.

Differential Revision: D70415647
YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Mar 6, 2025
@YIWENX14 @facebook-github-bot
Add buck rules in coreml llama transformer (pytorch#9017)
a2ac2cc 
Summary:

Add buck rules in coreml llama transformer for importing the modules to internal repo.

Differential Revision: D70415647
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Mar 6, 2025
@YIWENX14 @facebook-github-bot
Add buck rules in coreml llama transformer (pytorch#9017)
e3441b0 
Summary:

Add buck rules in coreml llama transformer for importing the modules to internal repo.

Differential Revision: D70415647
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

cccclai
cccclai reviewed Mar 6, 2025
View reviewed changes
examples/apple/coreml/llama/TARGETS
"llama_transformer.py",
],
_is_external_target = True,
base_module = "executorch.examples.apple.coreml.llama",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding buck rules so the internal repo can import coreml llama modules from oss. Will replace the internal kv_io_sliding_llama definition.

metascroy
metascroy reviewed Mar 6, 2025
View reviewed changes
pyproject.toml Outdated
@@ -92,6 +92,7 @@ flatc = "executorch.data.bin:flatc"
# TODO(mnachin T180504136): Do not put examples/models
# into core pip packages. Refactor out the necessary utils
# or core models files into a separate package.
"executorch.examples.apple" = "examples/apple"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this more specific to examples/apple/coreml/llama?

@metascroy
Copy link
Contributor

@YIWENX14 lint check is failing. Can you run the OSS linter?

From executorch folder

lintrunner -a

(If lintrunner is not already installed, it can be installed with pip install -r requirements-lintrunner.txt from executorch).

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Mar 6, 2025
@YIWENX14 @facebook-github-bot
Add buck rules in coreml llama transformer (pytorch#9017)
6b34d20 
Summary:

Add buck rules in coreml llama transformer for importing the modules to internal repo.

Reviewed By: billmguo

Differential Revision: D70415647
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

@YIWENX14
Copy link
Contributor Author

YIWENX14 commented Mar 6, 2025

Fix lint issues and update module to subfolder examples/apple/coreml/llama.

@YIWENX14 @facebook-github-bot
Add buck rules in coreml llama transformer (pytorch#9017)
2b52cd8 
Summary:

Add buck rules in coreml llama transformer for importing the modules to internal repo.

Reviewed By: metascroy, billmguo

Differential Revision: D70415647
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70415647

@facebook-github-bot facebook-github-bot merged commit 337d73d into pytorch:main Mar 7, 2025
122 of 126 checks passed
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai left review comments

@billmguo billmguo billmguo approved these changes

@metascroy metascroy metascroy approved these changes

@cymbalrush cymbalrush Awaiting requested review from cymbalrush

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YIWENX14 @facebook-github-bot @metascroy @billmguo @cccclai