Modifying slice op to support all tensor packing. #9030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9030
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d286fb1 with merge base e673f7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
trivedivivek
force-pushed
the
export-D70559149
branch
from
420633f to
a6d50ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
SS-JIA
approved these changes
Mar 6, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Mar 7, 2025
Summary: This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
a6d50ac to
2d66762
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Mar 7, 2025
Summary: This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
2d66762 to
e0caa97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Mar 7, 2025
Summary: This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
e0caa97 to
31015dd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Mar 7, 2025
Summary: Pull Request resolved: pytorch#9030 This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
31015dd to
32372a5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Mar 7, 2025
Summary: This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
32372a5 to
9ecc5db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
Summary: This diff updates Executorch Vulkan backend's `slice_copy` operation to support width, height and channel packed tensors. It also updates the `op_registry.py` file to register the `slice_copy` operation and adds a new test case to the `cases.py` file to test the operation. Additionally, it updates the `Slice.cpp` file to check for the same packed dimension in the input and output tensors, and updates the `cases.py` file to include the `utils::kWidthPacked`, `utils::kHeightPacked`, and `utils::kChannelsPacked` layouts. Reviewed By: SS-JIA Differential Revision: D70559149
trivedivivek
force-pushed
the
export-D70559149
branch
from
9ecc5db to
d286fb1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70559149 |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates Executorch Vulkan backend's
slice_copyoperation to support width, height and channel packed tensors.It also updates the
op_registry.pyfile to register theslice_copyoperation and adds a new test case to thecases.pyfile to test the operation.Additionally, it updates the
Slice.cppfile to check for the same packed dimension in the input and output tensors, and updates thecases.pyfile to include theutils::kWidthPacked,utils::kHeightPacked, andutils::kChannelsPackedlayouts.Reviewed By: SS-JIA
Differential Revision: D70559149