Skip to content

Arm backend: Added 8 new unit tests for testing various passes. #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2025

Conversation

Michiel-Olieslagers
Copy link
Collaborator

@Michiel-Olieslagers Michiel-Olieslagers commented Mar 7, 2025

Refactored tests cases to use TestPassPipeline instead of ArmTester.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9037

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit a01db21 with merge base a073668 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@freddan80 freddan80 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 7, 2025
Copy link

pytorch-bot bot commented Mar 7, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Mar 7, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Mar 10, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@Michiel-Olieslagers
Copy link
Collaborator Author

There seems to be a lint runner issue showing unrelated to the Arm unit tests created in this PR.

@shoumikhin
Copy link
Contributor

@digantdesai, @kirklandsign can you take a look please?

Copy link

pytorch-bot bot commented Mar 19, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess TOSA version shouldn't matter since most are just checking the decomp tables, right?

Refactored tests cases to use TestPassPipeline instead of ArmTester
(Removed all rights reserved)

Signed-off-by: Michiel Olieslagers <[email protected]>
Change-Id: Ib5e9051dc6299a499423bfc73f1c74d3e4a1225f
@zingo
Copy link
Collaborator

zingo commented Apr 14, 2025

MacOS Fails is unrelated!

@zingo zingo merged commit 8e89094 into pytorch:main Apr 14, 2025
166 of 167 checks passed
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
…rch#9037)

Refactored tests cases to use TestPassPipeline instead of ArmTester.

Signed-off-by: Michiel Olieslagers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants