Split delinearize_index out of broadcast_util #9056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2025
swolchok
requested review from
larryliu0820,
kirklandsign,
kimishpatel,
jackzhxng,
iseeyuan and
GregoryComer
as code owners
JacobSzwejbka
approved these changes
Mar 11, 2025
| void delinearize_index( | ||
| size_t linear_index, | ||
| executorch::aten::ArrayRef<Tensor::SizesType> shape, | ||
| size_t* out_indexes, |
There was a problem hiding this comment.
Not particularly interested in changing API here because 1) out of scope for this diff 2) might break backward compatibility 3) don't see a reason to migrate between the two equivalent reference-to-array classes.
There was a problem hiding this comment.
- don't see a reason to migrate between the two equivalent reference-to-array classes.
Ah I meant more for the bottom 2 args of * and length not the arrayref
| project(extension_parallel_test) | ||
|
|
||
| # Use C++17 for test. | ||
| set(CMAKE_CXX_STANDARD 17) |
There was a problem hiding this comment.
Why'd the standard line go away?
| } // namespace executor | ||
| } // namespace torch | ||
| // This header is a stub left behind after the move to | ||
| // executorch/runtime/kernel. As such, it is deprecated; include and |
There was a problem hiding this comment.
were any of our tutorials using thread_parallel.h?
There was a problem hiding this comment.
code search says no
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left an #include behind for backward compatibility. Just needed so that broadcast_indexes_range.h can use delinearize_index