Don't use designated initializers in QueryPool.cpp #9116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9116
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 45051b9 with merge base 56adfd4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SamGondelman
added
the
release notes: build
|
This pull request was exported from Phabricator. Differential Revision: D70933388 |
|
This pull request was exported from Phabricator. Differential Revision: D70933388 |
SamGondelman
force-pushed
the
export-D70933388
branch
from
c3b0e54 to
02d7be6
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Mar 11, 2025
Summary: This is a c++20 feature, but not all clients are on c++20. Differential Revision: D70933388
SamGondelman
force-pushed
the
export-D70933388
branch
from
02d7be6 to
6899679
Compare
Summary: Pull Request resolved: pytorch#9116 This is a c++20 feature, but not all clients are on c++20. Differential Revision: D70933388
|
This pull request was exported from Phabricator. Differential Revision: D70933388 |
SamGondelman
force-pushed
the
export-D70933388
branch
from
6899679 to
45051b9
Compare
SS-JIA
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is a c++20 feature, but not all clients are on c++20.
Differential Revision: D70933388