[ET-VK] Add buffer support for binary ops #9164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #9096 ## Context In some cases, a shader can be compiled successfully with `glslc`, but if an optimization flag such as `-O` or `-Os` is used, the compilation will fail with a message similar to ``` internal error: compilation succeeded but failed to optimize: Invalid use of 8- or 16-bit result\n %133 = OpExtInst %half %1 Pow %125 %132 ``` Which will cause the shader compilation script to fail. This diff introduces a check that if `glslc` complains about not being able to optimize the SPIR-V, then retry compilation without optimization arguments. ghstack-source-id: 271044834 @exported-using-ghexport Differential Revision: [D70906097](https://our.internmc.facebook.com/intern/diff/D70906097/)
Pull Request resolved: #9063 ## Context As title; add an implementation for binary operators for buffer-backed tensors. ghstack-source-id: 271044833 @exported-using-ghexport Differential Revision: [D70810338](https://our.internmc.facebook.com/intern/diff/D70810338/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9164
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 41 PendingAs of commit 16cccd3 with merge base ddf0d9e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9063 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/193/orig
@diff-train-skip-merge