[build Folder Migration] Move build/Codegen.cmake #9185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9185
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Unrelated FailureAs of commit 3061b7c with merge base 753da9a ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
added
the
module: build/install
jathu
requested review from
tarun292,
manuelcandales,
swolchok,
jackzhxng,
iseeyuan,
lucylq,
JacobSzwejbka,
cccclai,
digantdesai,
shoumikhin,
GregoryComer and
kirklandsign
as code owners
jathu
changed the title
mergennachin
approved these changes
Mar 12, 2025
swolchok
approved these changes
Mar 12, 2025
jathu
force-pushed
the
jathu/9117-move-cmake-files
branch
from
69842f0 to
232c593
Compare
jathu
force-pushed
the
jathu/9117-move-cmake-files
branch
from
8ebf293 to
3061b7c
Compare
|
These failing tests are unrelated to this diff:
|
jathu
added a commit
that referenced
this pull request
Mar 17, 2025
### Summary I know I moved this into `scripts/build` in #9185, but I think `tools/cmake` makes more sense. This will fit perfectly with `tools/buck` (D71267118), etc. ### Test plan CI cc @larryliu0820 @lucylq
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
### Summary I know I moved this into `scripts/build` in pytorch#9185, but I think `tools/cmake` makes more sense. This will fit perfectly with `tools/buck` (D71267118), etc. ### Test plan CI cc @larryliu0820 @lucylq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A series of diffs as a part of #9117. Move it from
./build→./scripts/buildTest plan
CI
cc @larryliu0820 @lucylq