-
Notifications
You must be signed in to change notification settings - Fork 589
Test MV3 model in CI wheel builds #9192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9192
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 2 Unrelated FailuresAs of commit 61d2afe with merge base a05c4da ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
52bb7b0
to
ed5444f
Compare
a9a24d4
to
11c818b
Compare
11c818b
to
d768b30
Compare
d768b30
to
00af75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is way better than before and thanks for adding the test after building the wheel.
os.path.join(_repository_root_dir(), ".ci/scripts/test_model.sh"), | ||
str(model_test.model), | ||
# What to build `executor_runner` with for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need so many redirections?
Can we just call this command directly in the .yml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having this
smoke-test-script: ${{ matrix.smoke-test-script }}
can we just run the script directly, similar to how we do in pull.yml and trunk.yml
I don't think this is possible with the current job template, it only support running python scripts: |
fb34916
to
8880b82
Compare
8880b82
to
61d2afe
Compare
### Summary As part of pytorch#9019, we want to ensure we can export models on P0 hosts targeting P0 backends. So, let's test this in our wheel creation. For now, we introduce macOS/Linux XNNPACK export. Given the wheel building GitHub workflow doesn't support using jobs as a test step, we must go use a python script. This runs a similar test to what we do in PRs: https://github.com/pytorch/executorch/blob/1011fdc98bcd61063b845670fb1779635aa30e3a/.github/workflows/pull.yml#L85-L136 ### Test plan CI → Build {Linux, macOS} Wheels cc @larryliu0820 @lucylq
### Summary As part of pytorch#9019, we want to ensure we can export models on P0 hosts targeting P0 backends. So, let's test this in our wheel creation. For now, we introduce macOS/Linux XNNPACK export. Given the wheel building GitHub workflow doesn't support using jobs as a test step, we must go use a python script. This runs a similar test to what we do in PRs: https://github.com/pytorch/executorch/blob/1011fdc98bcd61063b845670fb1779635aa30e3a/.github/workflows/pull.yml#L85-L136 ### Test plan CI → Build {Linux, macOS} Wheels cc @larryliu0820 @lucylq
Summary
As part of #9019, we want to ensure we can export models on P0 hosts targeting P0 backends. So, let's test this in our wheel creation. For now, we introduce macOS/Linux XNNPACK export.
Given the wheel building GitHub workflow doesn't support using jobs as a test step, we must go use a python script. This runs a similar test to what we do in PRs:
executorch/.github/workflows/pull.yml
Lines 85 to 136 in 1011fdc
Test plan
CI → Build {Linux, macOS} Wheels
cc @larryliu0820 @lucylq