Skip to content

Include libcpublas.a into optimized kernels framework #9218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

shoumikhin
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9218

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 0810ce5 with merge base e3de804 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
@shoumikhin
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@huydhn
Copy link
Contributor

huydhn commented Mar 13, 2025

Hmm, the job is still failing I think. It's the build error now coming from abseil-cpp, this is weird as I see you already have the commit to recursively check out

2025-03-13T06:53:16.4310040Z CMake Warning:
2025-03-13T06:53:16.4310220Z   Ignoring extra path from command line:
2025-03-13T06:53:16.4310370Z 
2025-03-13T06:53:16.4310770Z    "/Users/runner/work/executorch/executorch/pytorch/executorch/extension/benchmark/apple/Benchmark/../../../llm/tokenizers/third-party/abseil-cpp"
2025-03-13T06:53:16.4311220Z 
2025-03-13T06:53:16.4311220Z 
2025-03-13T06:53:16.4311710Z CMake Error: The source directory "/Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/tokenizers/third-party/abseil-cpp" does not appear to contain CMakeLists.txt.

@shoumikhin shoumikhin merged commit cb3ec19 into main Mar 13, 2025
55 of 59 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-3 branch March 13, 2025 16:14
@shoumikhin
Copy link
Contributor Author

shoumikhin commented Mar 13, 2025

@huydhn exactly, that's why I'm wondering if that approach works.
It builds and runs flawlessly for me locally when I git clone recursively.

@huydhn
Copy link
Contributor

huydhn commented Mar 13, 2025

I look at the logs and see that submodules parameter was set to true https://github.com/pytorch/executorch/actions/runs/13827845229/job/38685932365?pr=9218#step:5:7, so I think it will work in main where the parameter has been set to recursive. I thought the PR should do the same, but I think I'm missing something here.

@huydhn
Copy link
Contributor

huydhn commented Mar 13, 2025

Anyway, the workflow used in this PR https://github.com/pytorch/executorch/actions/runs/13827845229/workflow#L282 still had submodules set to true, that's why the build job fails. The fix for the PR would be to do a rebase to latest main branch. As this has been merged, we will observe it in main branch then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants