-
Notifications
You must be signed in to change notification settings - Fork 536
Include libcpublas.a into optimized kernels framework #9218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9218
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 0810ce5 with merge base e3de804 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
Hmm, the job is still failing I think. It's the build error now coming from
|
@huydhn exactly, that's why I'm wondering if that approach works. |
I look at the logs and see that submodules parameter was set to true https://github.com/pytorch/executorch/actions/runs/13827845229/job/38685932365?pr=9218#step:5:7, so I think it will work in main where the parameter has been set to recursive. I thought the PR should do the same, but I think I'm missing something here. |
Anyway, the workflow used in this PR https://github.com/pytorch/executorch/actions/runs/13827845229/workflow#L282 still had submodules set to true, that's why the build job fails. The fix for the PR would be to do a rebase to latest main branch. As this has been merged, we will observe it in main branch then :) |
No description provided.