Skip to content

Unbreak unittest-buck #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Unbreak unittest-buck #9315

merged 1 commit into from
Mar 17, 2025

Conversation

swolchok
Copy link
Contributor

Fixed a couple clear OSS build problems, but ran into blockers (supported_features doesn't work in OSS buck), so just dropping prim_ops_test_cpp from OSS unittest-buck.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 17, 2025

Copy link

pytorch-bot bot commented Mar 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9315

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
Copy link
Contributor Author

seeing torchgen_files error on unittest-buck for mac; IIRC this is flaking (no idea how but I bet it's the runner only having these files sometimes) and so I'm landing anyway once unittest-buck for linux passes since this is a clear step forward

@swolchok swolchok merged commit 2303947 into main Mar 17, 2025
156 of 161 checks passed
@swolchok swolchok deleted the gh/swolchok/371/head branch March 17, 2025 15:46
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Fixed a couple clear OSS build problems, but ran into blockers
(supported_features doesn't work in OSS buck), so just dropping
prim_ops_test_cpp from OSS unittest-buck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants