Arm backend: Tosa tools update #9451

per · 2025-03-20T14:58:06Z

Summary

Move the tosa tools v0.80 to a separate namespace to be able to install the upcoming 1.0 release
in it's place.

Test plan

Tested through the Arm backend unit test flow.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

pytorch-bot · 2025-03-20T14:58:12Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9451

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit f793f79 with merge base 9b7a878 ():

NEW FAILURES - The following jobs have failed:

pull / unittest-arm / linux-job (gh)
RuntimeError: Command docker exec -t abb99bd403808b4ae1723f5da50b0cbb9381da5a3bf2cd0beac86f34b3aa84ff /exec failed with exit code 1
trunk / test-arm-reference-delegation / linux-job (gh)
RuntimeError: Command docker exec -t 69d5bc1adbedde93c31428e02fa3673b0ce2be747de7f105205b73761f5ded66 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

digantdesai

I think I understand what is happening but can't say I understand the rationale? Are we planning to have two versions co-exist?

Also this will cause chaos internally if we merge it now :)

per · 2025-03-21T07:50:49Z

@digantdesai Yes, we plan to have the two versions coexist.
The rationale is that we want to start test the 1.0 TOSA flow (including github CI) and also be able to test backend compilers transition to 1.0 (on internal CI).
When everything is green on 1.0 we'll pull out the 0.80 version.

digantdesai · 2025-03-21T15:29:25Z

When everything is green on 1.0 we'll pull out the 0.80 version.

Though OK for GH OSS, it will be a headache internally. Curious, can we test the 1.0 on a branch on GH and once we are ready we can just drop 0.80? Assuming 1.0 is BC with 0.80 of tosa tools. This will save some throwaway efforts on my side internally.

per · 2025-03-25T09:02:52Z

1.0 on a branch on GH and once we are ready we can just drop 0.80? Assuming 1.0 is BC with 0.80 of tosa tools

The 1.0 tooling is not backward compatible with 0.80 unfortunately. Getting this in will let us develop the 1.0 support for reference in parallel as the compiler gets it's support.

per · 2025-03-26T20:31:24Z

@digantdesai Good to go?

per · 2025-03-26T22:44:33Z

Unrelated failure: trunk / test-models-linux-aarch64 (phi_4_mini, portable) / linux-job (push)

facebook-github-bot · 2025-03-28T18:43:14Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2025-03-28T18:44:25Z

...atches/v0.80/reference_model/0001-Move-tosa-tools-to-be-namespaced-into-tosa-tools.v0_.patch

@@ -0,0 +1,154 @@
+From 20c2059723d5c6952cecfb7fcde92601639ef825 Mon Sep 17 00:00:00 2001


we need to pull this in

digantdesai · 2025-03-28T18:44:52Z

...del/patches/v0.80/serialization_lib/0001-Make-TOSA-serializer-lib-to-be-self-contained.patch

@@ -0,0 +1,283 @@
+From b3c8c3f779a7e051826f317598fb831fa9cfe923 Mon Sep 17 00:00:00 2001


digantdesai

I pulled this in, let's see how many different ways it fails, and what I need to do to fix it. Let's hold on to merging this until then? I should be able to do this early next week.

digantdesai · 2025-04-03T04:33:06Z

Sigh something didn't work right, running the internal CI again

zingo · 2025-04-04T07:11:37Z

@digantdesai

Sigh something didn't work right, running the internal CI again

Is the problems due to the change or other random things?
Is there some error you can share?

digantdesai · 2025-04-04T18:41:34Z

ok so the pull worked this time, as expected broke a bunch of things internally because this module doesn't exist. I am on PTO today, I will take a stab at this on Mon. Sorry for blocking this :(

digantdesai · 2025-04-08T03:14:40Z

Ok got this to work internally. I can merge it with internal stack or you can merge it and I can forward fix it.

If you are doing it, please rebase, fix where and erf ops, and I can pull in again, while it merges with internal, and get ready to apply the fix.

Else if you want me to merge it then perhaps, I have to commandeer this one and merge it with few other commits.

per · 2025-04-08T14:19:10Z

Thank you Digant! I've rebased and fixed the linterror in erf, couldn't see anything in where though. Let me know when you've imported it and I can merge.

In preparation to move to TOSA 1.0 release the 0.80 package is moved to it's own namespace to be able to handle both versions during the transition period. Signed-off-by: Per Åstrand <[email protected]> Change-Id: Ib653ae81125052f5105ff124b59155018c98aef5

NFC that moves to use the TOSA tools from a different namespace. Preparation to run 0.80 and 1.0 along side during the transition period. Signed-off-by: Per Åstrand <[email protected]> Change-Id: I69d6d6a46fa95213afde8952f151fc9b41065099

facebook-github-bot · 2025-04-09T18:40:26Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2025-04-09T18:46:05Z

@per - https://github.com/pytorch/executorch/blob/main/backends/arm/operators/op_where.py#L8

per · 2025-04-09T20:14:29Z

@per - https://github.com/pytorch/executorch/blob/main/backends/arm/operators/op_where.py#L8

@digantdesai Fixed here e3a5111#diff-bac7978e44db415ee063435c3f4a2eebe951296f01ade26b18afd4c9d30faa09R8 , right?
Or am I missing something?

per · 2025-04-09T20:27:19Z

Failures are caused by #9938.

SS-JIA · 2025-04-09T23:38:18Z

Will revert the PR as it is causing some internal failures as well.

SS-JIA · 2025-04-10T02:43:10Z

Decided to try and forward fix with #10043 since the PR has been synced to our internal repo already. PTAL!

Summary: Move the tosa tools v0.80 to a separate namespace to be able to install the upcoming 1.0 release in it's place. Pull Request resolved: pytorch#9451 Test Plan: Tested through the Arm backend unit test flow. cc digantdesai freddan80 zingo oscarandersson8218 Reviewed By: limintang Differential Revision: D72071739 Pulled By: digantdesai

Summary: Pull Request resolved: pytorch#10075 Move the tosa tools v0.80 to a separate namespace to be able to install the upcoming 1.0 release in it's place. Pull Request resolved: pytorch#9451 Test Plan: Tested through the Arm backend unit test flow. cc digantdesai freddan80 zingo oscarandersson8218 Reviewed By: SS-JIA, limintang Differential Revision: D72071739 Pulled By: digantdesai

Differential Revision: D72071739 Pull Request resolved: #10075

Differential Revision: D72071739 Pull Request resolved: pytorch#10075

per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 20, 2025

per requested a review from digantdesai as a code owner March 20, 2025 14:58

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025

digantdesai reviewed Mar 21, 2025

View reviewed changes

per force-pushed the tosa_tools_update_1 branch from 4367932 to 0fe745b Compare March 21, 2025 07:45

per force-pushed the tosa_tools_update_1 branch from 0fe745b to 128cd53 Compare March 24, 2025 11:24

per force-pushed the tosa_tools_update_1 branch 2 times, most recently from 34eb08b to 6434576 Compare March 26, 2025 08:22

per requested review from zingo and oscarandersson8218 March 26, 2025 14:41

per force-pushed the tosa_tools_update_1 branch 2 times, most recently from a524a54 to 18a2bbb Compare March 26, 2025 20:30

per force-pushed the tosa_tools_update_1 branch 6 times, most recently from 7064d03 to 2454103 Compare March 28, 2025 14:31

digantdesai reviewed Mar 28, 2025

View reviewed changes

zingo approved these changes Apr 4, 2025

View reviewed changes

per force-pushed the tosa_tools_update_1 branch from df483db to 54c04ad Compare April 4, 2025 10:05

per force-pushed the tosa_tools_update_1 branch from 54c04ad to de20246 Compare April 7, 2025 14:57

digantdesai approved these changes Apr 8, 2025

View reviewed changes

per force-pushed the tosa_tools_update_1 branch 2 times, most recently from 305176c to 3d560f9 Compare April 8, 2025 13:45

per added 2 commits April 8, 2025 18:43

per force-pushed the tosa_tools_update_1 branch from 3d560f9 to e3a5111 Compare April 8, 2025 16:43

oscarandersson8218 mentioned this pull request Apr 9, 2025

Arm backend: Add support for sqrt #9928

Merged

Merge branch 'main' into tosa_tools_update_1

f793f79

facebook-github-bot pushed a commit that referenced this pull request Apr 10, 2025

Arm backend: Tosa tools update (#9451)

76f2773

Differential Revision: D72071739 Pull Request resolved: #10075

kirklandsign pushed a commit that referenced this pull request Apr 11, 2025

Arm backend: Tosa tools update (#9451)

cd2aed4

Differential Revision: D72071739 Pull Request resolved: #10075

per closed this Apr 15, 2025

per deleted the tosa_tools_update_1 branch April 15, 2025 06:58

keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025

Arm backend: Tosa tools update (pytorch#9451)

defd83b

Differential Revision: D72071739 Pull Request resolved: pytorch#10075

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arm backend: Tosa tools update #9451

Arm backend: Tosa tools update #9451

per commented Mar 20, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 20, 2025 •

edited

Loading

digantdesai left a comment

per commented Mar 21, 2025

digantdesai commented Mar 21, 2025

per commented Mar 25, 2025

per commented Mar 26, 2025

per commented Mar 26, 2025

facebook-github-bot commented Mar 28, 2025

digantdesai Mar 28, 2025

digantdesai Mar 28, 2025

digantdesai left a comment

digantdesai commented Apr 3, 2025

zingo commented Apr 4, 2025

digantdesai commented Apr 4, 2025

digantdesai commented Apr 8, 2025

per commented Apr 8, 2025

facebook-github-bot commented Apr 9, 2025

digantdesai commented Apr 9, 2025

per commented Apr 9, 2025

per commented Apr 9, 2025

SS-JIA commented Apr 9, 2025

SS-JIA commented Apr 10, 2025

		@@ -0,0 +1,154 @@
		From 20c2059723d5c6952cecfb7fcde92601639ef825 Mon Sep 17 00:00:00 2001

		@@ -0,0 +1,283 @@
		From b3c8c3f779a7e051826f317598fb831fa9cfe923 Mon Sep 17 00:00:00 2001

Arm backend: Tosa tools update #9451

Arm backend: Tosa tools update #9451

Conversation

per commented Mar 20, 2025 • edited by pytorch-bot bot Loading

Summary

Test plan

pytorch-bot bot commented Mar 20, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9451

❌ 2 New Failures

digantdesai left a comment

Choose a reason for hiding this comment

per commented Mar 21, 2025

digantdesai commented Mar 21, 2025

per commented Mar 25, 2025

per commented Mar 26, 2025

per commented Mar 26, 2025

facebook-github-bot commented Mar 28, 2025

digantdesai Mar 28, 2025

Choose a reason for hiding this comment

digantdesai Mar 28, 2025

Choose a reason for hiding this comment

digantdesai left a comment

Choose a reason for hiding this comment

digantdesai commented Apr 3, 2025

zingo commented Apr 4, 2025

digantdesai commented Apr 4, 2025

digantdesai commented Apr 8, 2025

per commented Apr 8, 2025

facebook-github-bot commented Apr 9, 2025

digantdesai commented Apr 9, 2025

per commented Apr 9, 2025

per commented Apr 9, 2025

SS-JIA commented Apr 9, 2025

SS-JIA commented Apr 10, 2025

per commented Mar 20, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 20, 2025 •

edited

Loading