Arm backend: Fix flaky test LSTM by bumping allowed atol/rtol slightly #9452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I58fec922a83f507ad0229680a232c8c8b16523eb
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9452
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 47a5c97 with merge base 6fb42ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
added
partner: arm
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Mar 20, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Thanks. We can debug ATOL/RTOL issues in parallel and keep relaxed version on CI if we want, as opposed to unmarked flaky tests.
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
pytorch#9452) This fix some rare fails on the LSTM test as we seem to have been too close with the values. Signed-off-by: Zingo Andersen <[email protected]>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
pytorch#9452) This fix some rare fails on the LSTM test as we seem to have been too close with the values. Signed-off-by: Zingo Andersen <[email protected]>
zingo
deleted the
Arm-backend-Fix-flaky-test-LSTM-by-bumping-allowed-atol/rtol-slightly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix some rare fails on the LSTM test as we seem to have been too close with the values.
cc @digantdesai @freddan80 @per @oscarandersson8218