Make nightly versions consistent #9453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Make the git hash from 3/11 nightly consistent with https://hud.pytorch.org/pytorch/pytorch/commit/d962699548c6740bf5d0f3ccda933de3b6fca643 - Make torchtune nightly consistent
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9453
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 3c352fd with merge base 87dd81a ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mergennachin
commented
Mar 20, 2025
| @@ -1 +1 @@ | |||
| 08434df1f2f88c9770e59246caa2ff9c6f613270 | |||
| 295f2ed4d103017f7e19a7b8263ece606cd629db | |||
There was a problem hiding this comment.
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Mar 20, 2025
jathu
reviewed
Mar 20, 2025
Comment on lines
+70
to
+72
| # | ||
| # NOTE: If you're changing, make the corresponding change in .ci/docker/ci_commit_pins/pytorch.txt | ||
| # by picking the hash from the same date in https://hud.pytorch.org/hud/pytorch/pytorch/nightly/ |
There was a problem hiding this comment.
There might be an opportunity to force compliance.
- We should create
./tools/setup/pytorch_nightly_version.txt, which hosts this version - In both files, we should read directly from that file
NIGHTLY_VERSION = open("${ROOT}/tools/setup/pytorch_nightly_version.txt", "r").read().strip()NIGHTLY_VERSION=$(cat "${ROOT}/tools/setup/pytorch_nightly_version.txt")
There was a problem hiding this comment.
Sorry, how do we find the mapping between git commit hash and nightly version?
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
Summary: - Make the git hash from 3/11 nightly consistent with https://hud.pytorch.org/pytorch/pytorch/commit/d962699548c6740bf5d0f3ccda933de3b6fca643 - Make torchtune nightly consistent
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
Summary: - Make the git hash from 3/11 nightly consistent with https://hud.pytorch.org/pytorch/pytorch/commit/d962699548c6740bf5d0f3ccda933de3b6fca643 - Make torchtune nightly consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: