Skip to content

Upgrade cmake on CI #9471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Upgrade cmake on CI #9471

merged 2 commits into from
Mar 21, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 20, 2025

This is the minimum version cmake_minimum_required(VERSION 3.24) set by #9248. Android jobs are failing https://github.com/pytorch/executorch/actions/runs/13959323278/job/39077616882#step:15:753 after #9248 lands

@huydhn huydhn requested a review from kirklandsign March 20, 2025 20:00
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9471

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Pending, 1 Unrelated Failure

As of commit 4c39f2f with merge base 3bb28ba (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@huydhn huydhn changed the title Use cmake 3.24 on CI Upgrade cmake on CI Mar 20, 2025
@huydhn huydhn marked this pull request as ready for review March 20, 2025 20:20
@huydhn
Copy link
Contributor Author

huydhn commented Mar 20, 2025

Let me run a round of Android perf job before landing this https://github.com/pytorch/executorch/actions/runs/13978908918

@huydhn huydhn temporarily deployed to upload-benchmark-results March 20, 2025 21:28 — with GitHub Actions Inactive
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results March 20, 2025 23:24 — with GitHub Actions Inactive
@huydhn huydhn merged commit 5fdfa51 into main Mar 21, 2025
156 of 160 checks passed
@huydhn huydhn deleted the upgrade-cmake-version-on-ci branch March 21, 2025 00:03
@huydhn huydhn temporarily deployed to upload-benchmark-results March 21, 2025 00:34 — with GitHub Actions Inactive
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
This is the minimum version `cmake_minimum_required(VERSION 3.24)` set
by pytorch#9248. Android jobs are
failing
https://github.com/pytorch/executorch/actions/runs/13959323278/job/39077616882#step:15:753
after pytorch#9248 lands
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
This is the minimum version `cmake_minimum_required(VERSION 3.24)` set
by pytorch#9248. Android jobs are
failing
https://github.com/pytorch/executorch/actions/runs/13959323278/job/39077616882#step:15:753
after pytorch#9248 lands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants