Skip to content

Migrate java api: LlamaModule -> LlmModule #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 21, 2025
Merged

Migrate java api: LlamaModule -> LlmModule #9478

merged 10 commits into from
Mar 21, 2025

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9478

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 2e9ae2b with merge base 079e54e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@kirklandsign kirklandsign added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Mar 20, 2025
@kirklandsign kirklandsign marked this pull request as ready for review March 20, 2025 23:34
@kirklandsign kirklandsign requested review from larryliu0820, lucylq and cmodi-meta and removed request for larryliu0820 March 20, 2025 23:34
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820
larryliu0820 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results March 21, 2025 04:51 — with GitHub Actions Inactive
@facebook-github-bot facebook-github-bot merged commit a6cd1dc into main Mar 21, 2025
87 of 91 checks passed
@facebook-github-bot facebook-github-bot deleted the migrate-java-api branch March 21, 2025 07:43
mergennachin
mergennachin reviewed Mar 21, 2025
View reviewed changes
extension/android/src/main/java/org/pytorch/executorch/LlamaCallback.java
*/
@Experimental
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was already tagged as experimental to begin with, we should just delete this altogether with 0.6 release. We don't need to keep for two releases, like we do with stable APIs.

https://pytorch.org/executorch/main/api-life-cycle.html#api-life-cycle

DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
@kirklandsign @DannyYuyang-quic
Migrate java api
b334598 
Differential Revision: D71588845

Pull Request resolved: pytorch#9478
@kirklandsign kirklandsign changed the title Migrate java api Migrate java api: LlamaModule -> LlmModule Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin left review comments

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@lucylq lucylq Awaiting requested review from lucylq

@cmodi-meta cmodi-meta Awaiting requested review from cmodi-meta

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirklandsign @facebook-github-bot @mergennachin @larryliu0820