[ET-VK] Cache compiled SPIR-V and only recompile when changed #9652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context As title. Introduce a caching mechanism to store SPIR-V generated in a previous build to avoid re-compiling them. A shader will not be re-compiled if the source GLSL template is unchanged. For Meta internal builds, the `etvk.force_shader_rebuild` buck config can be used to force all shaders to be built without using the cache. Differential Revision: [D71916745](https://our.internmc.facebook.com/intern/diff/D71916745/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9652
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit be86fb1 with merge base 7159650 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
## Context As title. Introduce a caching mechanism to store SPIR-V generated in a previous build to avoid re-compiling them. A shader will not be re-compiled if the source GLSL template is unchanged. For Meta internal builds, the `etvk.force_shader_rebuild` buck config can be used to force all shaders to be built without using the cache. Differential Revision: [D71916745](https://our.internmc.facebook.com/intern/diff/D71916745/) ghstack-source-id: 274260421 Pull Request resolved: #9652
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71916745 |
This PR needs a
|
yipjustin
approved these changes
Mar 26, 2025
…ged" ## Context As title. Introduce a caching mechanism to store SPIR-V generated in a previous build to avoid re-compiling them. A shader will not be re-compiled if the source GLSL template is unchanged. For Meta internal builds, the `etvk.force_shader_rebuild` buck config can be used to force all shaders to be built without using the cache. Differential Revision: [D71916745](https://our.internmc.facebook.com/intern/diff/D71916745/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
Pull Request resolved: #9652 ## Context As title. Introduce a caching mechanism to store SPIR-V generated in a previous build to avoid re-compiling them. A shader will not be re-compiled if the source GLSL template is unchanged. For Meta internal builds, the `etvk.force_shader_rebuild` buck config can be used to force all shaders to be built without using the cache. ghstack-source-id: 274281888 @exported-using-ghexport Differential Revision: [D71916745](https://our.internmc.facebook.com/intern/diff/D71916745/)
|
This pull request was exported from Phabricator. Differential Revision: D71916745 |
facebook-github-bot
merged commit 2f316c6
into
gh/SS-JIA/202/base
82 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Mar 27, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9652 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/orig @diff-train-skip-merge Co-authored-by: Stephen Jia <[email protected]>
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9652 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/202/orig @diff-train-skip-merge Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
As title. Introduce a caching mechanism to store SPIR-V generated in a previous build to avoid re-compiling them.
A shader will not be re-compiled if the source GLSL template is unchanged.
For Meta internal builds, the
etvk.force_shader_rebuildbuck config can be used to force all shaders to be built without using the cache.Differential Revision: D71916745