Improve ET_CHECK_OR_RETURN_FALSE error messages in kernels/portable #9751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9751
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d9b339b with merge base 65ebabb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 28, 2025
We have a lot of `ET_CHECK_OR_RETURN_FALSE` that log a condition, but not the values of the variables in that condition. This is an attempt to improve debuggability of these errors. ghstack-source-id: db6393ef8976772316b3ac99372ae3487beebeae ghstack-comment-id: 2762245084 Pull-Request-resolved: #9751
facebook-github-bot
added
the
CLA Signed
manuelcandales
approved these changes
Mar 28, 2025
swolchok
added
module: kernels
swolchok
added a commit
that referenced
this pull request
Mar 31, 2025
ghstack-source-id: 2dcf8fe2d819bf730dbf18d0790d55f691754caa ghstack-comment-id: 2766812039 Pull-Request-resolved: #9768 #9751 added a bunch of logging to error messages. We discovered after commit that it caused -Wformat warnings (turned into errors via -Werror) in ATen mode, because a bunch of Tensor methods return different types between ExecuTorch and ATen. This PR adds formatting macros to be used with this methods and uses them.
swolchok
added a commit
that referenced
this pull request
Mar 31, 2025
#9751 added a bunch of logging to error messages. We discovered after commit that it caused -Wformat warnings (turned into errors via -Werror) in ATen mode, because a bunch of Tensor methods return different types between ExecuTorch and ATen. This PR adds formatting macros to be used with this methods and uses them.
swolchok
added a commit
that referenced
this pull request
Apr 2, 2025
I forgot that we have a nice system for logging ScalarTypes as strings already. Let's use it. ghstack-source-id: ed9f7fdd9ec36666837adf413718e35d9334b0fd ghstack-comment-id: 2773731655 Pull Request resolved: #9845
swolchok
added a commit
that referenced
this pull request
Apr 3, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
…9751) We have a lot of `ET_CHECK_OR_RETURN_FALSE` that log a condition, but not the values of the variables in that condition. This is an attempt to improve debuggability of these errors. cc @larryliu0820 @manuelcandales
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
#9751 added a bunch of logging to error messages. We discovered after commit that it caused -Wformat warnings (turned into errors via -Werror) in ATen mode, because a bunch of Tensor methods return different types between ExecuTorch and ATen. This PR adds formatting macros to be used with this methods and uses them.
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of
ET_CHECK_OR_RETURN_FALSEthat log a condition, butnot the values of the variables in that condition. This is an attempt
to improve debuggability of these errors.
cc @larryliu0820 @manuelcandales