Skip to content

Arm backend: Add ERF operator #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Arm backend: Add ERF operator #9836

merged 3 commits into from
Apr 4, 2025

Conversation

maddun01
Copy link
Collaborator

@maddun01 maddun01 commented Apr 2, 2025

  • Register ERF node visitor for MI case
  • BI handled by table op pass
  • Add tests

Change-Id: I471903fc14ce474d21ee91b5f8f916e0474bb7db

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Register ERF node visitor for MI case
- BI handled by table op pass
- Add tests

Signed-off-by: Madeleine Dunn <[email protected]>
Change-Id: I471903fc14ce474d21ee91b5f8f916e0474bb7db
@maddun01 maddun01 requested a review from digantdesai as a code owner April 2, 2025 14:07
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9836

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 0528b5f with merge base 4717459 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2025
@maddun01
Copy link
Collaborator Author

maddun01 commented Apr 2, 2025

@pytorchbot label ciflow/trunk

Copy link

pytorch-bot bot commented Apr 2, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@maddun01
Copy link
Collaborator Author

maddun01 commented Apr 2, 2025

@pytorchbot label "topic: not user facing"

@maddun01
Copy link
Collaborator Author

maddun01 commented Apr 2, 2025

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 2, 2025
Copy link

pytorch-bot bot commented Apr 2, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Apr 2, 2025
@digantdesai
Copy link
Contributor

Added you to the Contributors list, hopefully CI will run automatic from next push. Welcome to ExecuTorch :)

@zingo zingo merged commit 0efdb91 into pytorch:main Apr 4, 2025
165 of 167 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
- Register ERF node visitor for MI case
- BI handled by table op pass
- Add tests

Signed-off-by: Madeleine Dunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants