Skip to content

RMSNorm support - Executorch #9844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

ThomasJannaud
Copy link
Contributor

Summary:
This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Differential Revision: D72258890

@ThomasJannaud ThomasJannaud requested a review from tarun292 as a code owner April 2, 2025 17:37
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9844

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a719008 with merge base 0844c38 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:
Pull Request resolved: pytorch#9844

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@ThomasJannaud ThomasJannaud force-pushed the export-D72258890 branch 2 times, most recently from 89644d2 to 5710cb5 Compare April 3, 2025 15:22
ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:
Pull Request resolved: pytorch#9844

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:
Pull Request resolved: pytorch#9844

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:
Pull Request resolved: pytorch#9844

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

ThomasJannaud added a commit to ThomasJannaud/executorch that referenced this pull request Apr 3, 2025
Summary:
Pull Request resolved: pytorch#9844

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
Summary:

This follows D72014553 which adds support for RMSNorm (cpu backend)
This is a separate diff for Executorch / Github

Reviewed By: Vysarat

Differential Revision: D72258890
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72258890

@facebook-github-bot facebook-github-bot merged commit 3fc1a97 into pytorch:main Apr 3, 2025
81 of 82 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Differential Revision: D72258890

Pull Request resolved: #9844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants