Arm backend: Convert assert to throw ValueError in op_tanh #9896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts are converted to proper raises to ensure graph integrity. It should not be possible for tanh to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. torch.tanh supports more data types than fp32, which is why it should be checked. Change-Id: Ibbe2f6964f85ee6c5883fdbe8973526ff6f224cd Signed-off-by: Sebastian Larsson <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9896
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 998ad74 with merge base 4717459 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
added
partner: arm
zingo
approved these changes
Apr 4, 2025
|
fails are unrelated |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Asserts are converted to proper raises to ensure graph integrity. It should not be possible for tanh to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. torch.tanh supports more data types than fp32, which is why it should be checked. Signed-off-by: Sebastian Larsson <[email protected]>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts are converted to proper raises to ensure graph integrity.
It should not be possible for tanh to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly.
torch.tanh supports more data types than fp32, which is why it should be checked.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218