Arm backend: Convert assert to throw ValueError in tosa_backend #9905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a risk with using asserts in production code as it might get optimized out. A proper error is raised instead. Change-Id: Ie10348c65c3d45a4773efbbcbc0686cd9007b800 Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9905
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0d00825 with merge base cfca108 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Apr 4, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
There's a risk with using asserts in production code as it might get optimized out. A proper error is raised instead. Signed-off-by: Sebastian Larsson <[email protected]>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a risk with using asserts in production code as it might get optimized out. A proper error is raised instead.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218