Just build AAR in place #9985
Just build AAR in place #9985
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9985
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b1bb302 with merge base 7e8acb9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
the
release notes: build
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| popd | ||
| cp extension/android/executorch_android/build/outputs/aar/executorch_android-debug.aar "${BUILD_AAR_DIR}/executorch.aar" |
There was a problem hiding this comment.
Question - do we still leave a .aar file behind?
There was a problem hiding this comment.
Sorry trying to understand your question:
extension/android/executorch_android/build/outputs/aar/executorch_android-debug.aar is the original output from gradle script, without any manual action. You can interpret it as a final proeuct, and we leave it there. Now I copied it to "${BUILD_AAR_DIR}/executorch.aar" (say aar-out/executorch.aar) and later user can just copy from aar-out/executorch.aar to their apps, instead of copying from the long path extension/android/executorch_android/build/outputs/aar/executorch_android-debug.aar.
There was a problem hiding this comment.
ah ok that makes sense.
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Differential Revision: D72679075 Pull Request resolved: #9985
Differential Revision: D72679075 Pull Request resolved: pytorch#9985
No description provided.