Skip to content

[skip ci] Update MNIST_on_TPU.ipynb#2252

Merged
vfdev-5 merged 3 commits intopytorch:masterfrom
FarehaNousheen:linkupdate
Oct 14, 2021
Merged

[skip ci] Update MNIST_on_TPU.ipynb#2252
vfdev-5 merged 3 commits intopytorch:masterfrom
FarehaNousheen:linkupdate

Conversation

@FarehaNousheen
Copy link
Copy Markdown
Contributor

@FarehaNousheen FarehaNousheen commented Oct 6, 2021 •
edited by vfdev-5
Loading

Fixes #2239

Description: Update Install links for PyTorch XLA in MNIST TPU

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • The PyTorch XLA install link is updated

@github-actions github-actions bot added the examples Examples label Oct 6, 2021
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Oct 6, 2021

Looks good ! Thanks @FarehaNousheen

Notebook can be checked here:

https://colab.research.google.com/github/pytorch/ignite/blob/3d392238c2a5572233ac370c004682e16bcdeb63/examples/notebooks/MNIST_on_TPU.ipynb

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Oct 6, 2021 •
edited
Loading

@FarehaNousheen could you please also add missing f-strings:

    pbar.log_message(
-        "Training Results - Epoch: {engine.state.epoch}  Avg accuracy: {avg_accuracy:.2f} Avg loss: {avg_nll:.2f}"
+        f"Training Results - Epoch: {engine.state.epoch}  Avg accuracy: {avg_accuracy:.2f} Avg loss: {avg_nll:.2f}"
    )

and

    print(
-        "Validation Results - Epoch: {engine.state.epoch}  Avg accuracy: {avg_accuracy:.2f} Avg loss: {avg_nll:.2f}"
+        f"Validation Results - Epoch: {engine.state.epoch}  Avg accuracy: {avg_accuracy:.2f} Avg loss: {avg_nll:.2f}"
    )

@vfdev-5 vfdev-5 changed the title Update MNIST_on_TPU.ipynb [skip ci] Update MNIST_on_TPU.ipynb Oct 6, 2021
@FarehaNousheen
Copy link
Copy Markdown
Contributor Author

FarehaNousheen commented Oct 7, 2021 via email

@Ishan-Kumar2
Copy link
Copy Markdown
Contributor

Ishan-Kumar2 commented Oct 7, 2021

Hi @FarehaNousheen thanks for the changes.
I think your latest commit has messed up the notebook JSON format. I am not able to open it here and locally.
It might have been caused due to making edits in the raw format, to fix it you can remove the changes in the last commit and then update the text after opening as a Jupyter notebook.

@FarehaNousheen
Copy link
Copy Markdown
Contributor Author

FarehaNousheen commented Oct 8, 2021 via email

vfdev-5
vfdev-5 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FarehaNousheen !

@vfdev-5 vfdev-5 merged commit 9468c0a into pytorch:master Oct 14, 2021
@FarehaNousheen
Copy link
Copy Markdown
Contributor Author

FarehaNousheen commented Oct 14, 2021

The notebook is checked on google collab. Sharing the link below for further step.
https://colab.research.google.com/github/pytorch/ignite/blob/118b16a529a14e28eadde37d92cfc88305ab3932/examples/notebooks/MNIST_on_TPU.ipynb

@FarehaNousheen
Copy link
Copy Markdown
Contributor Author

FarehaNousheen commented Oct 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

examples Examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update install links for PyTorch XLA in MNIST TPU example

3 participants

@FarehaNousheen @vfdev-5 @Ishan-Kumar2