[local linter] mypy_wrapper doesn't filter out distributed file

[driazati]

mypy_wrapper's logic for excluding files doesn't totally match up with mypy itself (though the file below isn't listed in mypy.ini's excludes, so who knows what's really going on)

# this fails (but shouldn't lint this file at all)
python tools/mypy_wrapper.py $(pwd)/torch/nn/parallel/distributed.py

# but this works
mypy --config mypy.ini 

[samestep]

Just tested this on commit c911c30 and it's still happening, so it was not fixed by #57998.

[samestep]

Ahh I understand now: I was thinking that this was about ignore_errors (which tools/mypy_wrapper.py does not need to handle), but it's actually about exclude, which we didn't have when I originally wrote our mypy wrapper, since it was added fairly recently in #55712.

[samestep]

I am a bit confused about what exactly is going on here, since torch/nn/parallel/distributed.py doesn't even match our current exclude regex:

pytorch/mypy.ini

Line 46 in d09abf0

exclude = torch/include/|torch/csrc/|torch/distributed/elastic/agent/server/api.py

(edit: whoops, I realize now that this fact is already noted in David's post above 😅)

[seemethere]

From triage meeting: solution should be a warning when mypy versions do not match

[samestep]

@seemethere that sounds like a different issue from what this thread is about?

[seemethere]

@seemethere that sounds like a different issue from what this thread is about?

We've concluded that the original issue stems from a mismatch of mypy versions, which is why a suggestion to warn when mypy versions do not match

[samestep]

oh I see; but I thought we already did that?

pytorch/mypy.ini

Line 5 in cae5ddc

plugins = mypy_plugins/check_mypy_version.py

pytorch/mypy-strict.ini

Line 10 in cae5ddc

plugins = mypy_plugins/check_mypy_version.py

[seemethere]

This has already been completed, going to close