[ET-VK] Enable Dynamic shape support via tensor virtual and physical resizing#122634
Closed
pytorchbot wants to merge 1 commit intorelease/2.3from
Closed
[ET-VK] Enable Dynamic shape support via tensor virtual and physical resizing#122634pytorchbot wants to merge 1 commit intorelease/2.3from
pytorchbot wants to merge 1 commit intorelease/2.3from
Conversation
…resizing (#121598) Summary: ## Context This changeset lays the foundations for supporting dynamic shapes in the ExecuTorch Vulkan delegate via allowing Tensors to be resized in one of two ways: 1. Discarding underlying `vkImage` or `vkBuffer` and reallocating a new `vkImage` or `vkBuffer` with updated sizes. This method is intended to be used when the current `vkImage` or `vkBuffer` is not large enough to contain the new sizes. 2. Update the tensor's size metadata without reallocating any new resources. This allows shaders to interpret the underlying `vkImage` or `vkBuffer` as if it were smaller than it actually is, and allows command buffers to be preserved when sizes are changed. Test Plan: Check CI. Tests have also been added to `vulkan_compute_api_test` that test the two methods of tensor resizing. Differential Revision: D54728401 Pull Request resolved: #121598 Approved by: https://github.com/jorgep31415 (cherry picked from commit cc51e10)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122634
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 621eb79 with merge base 86a2d67 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
This changeset lays the foundations for supporting dynamic shapes in the ExecuTorch Vulkan delegate via allowing Tensors to be resized in one of two ways:
vkImageorvkBufferand reallocating a newvkImageorvkBufferwith updated sizes. This method is intended to be used when the currentvkImageorvkBufferis not large enough to contain the new sizes.vkImageorvkBufferas if it were smaller than it actually is, and allows command buffers to be preserved when sizes are changed.Test Plan: Check CI. Tests have also been added to
vulkan_compute_api_testthat test the two methods of tensor resizing.Differential Revision: D54728401