Skip to content

Update third_party protobuf to v3.6.1 #16251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

bddppq
Copy link
Contributor

@bddppq bddppq commented Jan 23, 2019

No description provided.

@bddppq bddppq changed the title Testing Update third_party protobuf to v3.6.1 Jan 23, 2019
@Yangqing
Copy link
Contributor

Android failure seems to be related to protocolbuffers/protobuf#2719

@bddppq bddppq requested review from Yangqing and dzhulgakov January 23, 2019 08:08
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@t-vi
Copy link
Collaborator

t-vi commented Jan 23, 2019

Thank you for looking into this!

@t-vi t-vi mentioned this pull request Jan 23, 2019
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jan 23, 2019
Summary: Pull Request resolved: pytorch/pytorch#16251

Reviewed By: ezyang

Differential Revision: D13781444

Pulled By: bddppq

fbshipit-source-id: b713a021033d214f30a49ee02b95edf8633bcc50
@bddppq bddppq deleted the protobuf-v3.6.1 branch January 23, 2019 18:19
@ezyang ezyang added the merged label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants