Skip to content

Fix typing for load_state_dict_from_url() #76895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented May 5, 2022

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 5, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit fd1522a (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-05T15:45:43.4426139Z AssertionError: Found an invalid operator name: max_unpool2d_backward
2022-05-05T15:45:43.4422020Z   File "/var/lib/jenkins/workspace/torchgen/gen_backend_stubs.py", line 557, in <module>
2022-05-05T15:45:43.4422262Z     main()
2022-05-05T15:45:43.4422524Z   File "/var/lib/jenkins/workspace/torchgen/gen_backend_stubs.py", line 304, in main
2022-05-05T15:45:43.4422902Z     run(options.source_yaml, options.output_dir, options.dry_run, options.impl_path)
2022-05-05T15:45:43.4423292Z   File "/var/lib/jenkins/workspace/torchgen/gen_backend_stubs.py", line 498, in run
2022-05-05T15:45:43.4424284Z     source_yaml, grouped_native_functions, backend_indices
2022-05-05T15:45:43.4424653Z   File "/var/lib/jenkins/workspace/torchgen/gen_backend_stubs.py", line 143, in parse_backend_yaml
2022-05-05T15:45:43.4425097Z     use_device_guard=use_device_guard,
2022-05-05T15:45:43.4425476Z   File "/var/lib/jenkins/workspace/torchgen/gen_backend_stubs.py", line 118, in create_backend_index
2022-05-05T15:45:43.4425856Z     ), f"Found an invalid operator name: {op_name}"
2022-05-05T15:45:43.4426139Z AssertionError: Found an invalid operator name: max_unpool2d_backward
2022-05-05T15:45:43.4969654Z Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
2022-05-05T15:45:43.6520070Z + cleanup
2022-05-05T15:45:43.6520276Z + retcode=1
2022-05-05T15:45:43.6520444Z + set +x
2022-05-05T15:45:43.6560131Z ##[error]Process completed with exit code 1.
2022-05-05T15:45:43.6605684Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-05-05T15:45:43.6605923Z with:
2022-05-05T15:45:43.6606348Z   github-token: ***
2022-05-05T15:45:43.6606520Z env:
2022-05-05T15:45:43.6606663Z   IN_CI: 1

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@jbschlosser jbschlosser requested review from pmeier and albanD May 5, 2022 15:21
#74171 landed with an incorrect type for `load_state_dict_from_url()`. This PR fixes it. See the comment here: https://github.com/pytorch/pytorch/pull/74171/files/7f41d1ce0d0308258cfdd613477bb5e43068208d#r865982377

[ghstack-poisoned]
jbschlosser added a commit that referenced this pull request May 5, 2022
ghstack-source-id: 387912f
Pull Request resolved: #76895
Copy link
Contributor

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, sorry about the bug!

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Failing XLA test is unrelated.

@pmeier
Copy link
Collaborator

pmeier commented May 6, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Hey @jbschlosser.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@pmeier pmeier added module: typing Related to mypy type annotations topic: improvements topic category release notes: hub release notes category (torchhub) labels May 6, 2022
@facebook-github-bot facebook-github-bot deleted the gh/jbschlosser/39/head branch May 9, 2022 14:17
facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
Summary:
Pull Request resolved: #76895

Approved by: https://github.com/adamjstewart, https://github.com/albanD, https://github.com/pmeier

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ba818991afb4ef6189fa4ed57dd204173e9c7b74

Reviewed By: malfet

Differential Revision: D36201663

fbshipit-source-id: 781eaf530d136d95915ac85a8885dce7f270520d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: typing Related to mypy type annotations release notes: hub release notes category (torchhub) topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants