-
Notifications
You must be signed in to change notification settings - Fork 24.2k
Fix typing for load_state_dict_from_url() #76895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit fd1522a (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
#74171 landed with an incorrect type for `load_state_dict_from_url()`. This PR fixes it. See the comment here: https://github.com/pytorch/pytorch/pull/74171/files/7f41d1ce0d0308258cfdd613477bb5e43068208d#r865982377 [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, sorry about the bug!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix. Failing XLA test is unrelated.
@pytorchbot merge this please |
Hey @jbschlosser. |
Summary: Pull Request resolved: #76895 Approved by: https://github.com/adamjstewart, https://github.com/albanD, https://github.com/pmeier Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ba818991afb4ef6189fa4ed57dd204173e9c7b74 Reviewed By: malfet Differential Revision: D36201663 fbshipit-source-id: 781eaf530d136d95915ac85a8885dce7f270520d
Stack from ghstack:
#74171 landed with an incorrect type for
load_state_dict_from_url()
. This PR fixes it. See the comment here: https://github.com/pytorch/pytorch/pull/74171/files/7f41d1ce0d0308258cfdd613477bb5e43068208d#r865982377