Skip to content

[Educational] Typing .py files iteratively with mypy #1512

@msaroufim

Description

@msaroufim

We just added #1858 support so a good first issue for anyone new to torchserve or open source python projects in general I'd recommend the following

  1. Pick any file in serve/ts
  2. Add type annotations - for an example you can checkout https://github.com/pytorch/serve/blob/master/ts/context.py
  3. Run mypy path_to_file_you_annotated.py
  4. If you don't see any issues then make a PR and make sure the mypy lint action passes

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions