Skip to content

Update scripts to ROCm5.3 #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Dec 2, 2022

Needed for pytorch/vision#6955

@vercel
Copy link

vercel bot commented Dec 2, 2022

@jithunnair-amd is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm labels Dec 2, 2022
@jithunnair-amd jithunnair-amd marked this pull request as draft December 2, 2022 05:10
@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Dec 2, 2022

@osalpekar @kit1980 @malfet @atalman Do I need to make any other changes to any other files as part of this PR?

@osalpekar
Copy link
Member

osalpekar commented Dec 2, 2022

Thanks @jithunnair-amd! This should be good enough to move all the the nightly wheels across most of the domain libraries to the new rocm versions. I just authorized the build signal to run - will stamp once everything looks green

@jithunnair-amd jithunnair-amd marked this pull request as ready for review December 2, 2022 19:00
@jithunnair-amd
Copy link
Collaborator Author

Thanks @osalpekar, that sounds great. Would you mind elaborating a bit more on the vision forward for building nightly wheels? Some specific questions:

  1. Will this strategy eventually cover PyTorch nightly wheels as well, or only domain libraries such as vision, audio etc.? (so that we will not need to make some of the changes to switch to ROCm5.3 as in PRs ROCm5.3 nightly wheels builder#1193 and Upgrade nightly wheels to ROCm5.3 pytorch#89101?)
  2. Will PRs such as this become unnecessary going forward? Upgrade nightly wheels to ROCm5.3 vision#6955

@osalpekar
Copy link
Member

@jithunnair-amd Sure thing. There are 3 main components at work:

Re your questions:

  1. The plan is to use this across the entire PyTorch ecosystem! PyTorch core will use the existing method, but all the other repos will use these build components. At the moment, we've migrated torchtext, torchvision, and torchrec to this new workflow (deprecating CircleCI builds along the way). We're hoping to migrate torchaudio and torchdata in the coming few weeks. The remaining libraries are scheduled for migration early next year.
  2. That's right! Once the migration is all done, changing the versions in this build script will ensure the new versions are used across the whole ecosystem, so those PR's in each domain library will not be needed. (In fact, that is one of the reasons we're moving to this workflow.) However, until the migration is done, those PR's in each repo will be needed.

@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Dec 2, 2022

@osalpekar Thanks for the explanation. Looking forward to fewer PRs, w00t! I think the CI checks for ROCm passed, so this PR looks good to go?

@osalpekar osalpekar self-requested a review December 2, 2022 21:19
@jithunnair-amd
Copy link
Collaborator Author

@osalpekar Anything else needed to merge this PR? Thanks!

@osalpekar
Copy link
Member

@jithunnair-amd yep, good to go!

@osalpekar osalpekar merged commit 004bea5 into pytorch:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants