Skip to content

[cherry-pick] Add test to compare encoder inference on input with and without padding (#1770) #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Jun 7, 2022

  • add test to compare encoder inference on input with and without padding

  • remove bottom whitespace

  • remove unnecessary import

  • lint

…ng (pytorch#1770)

* add test to compare encoder inference on input with and without padding

* remove bottom whitespace

* remove unnecessary import

* lint
@Nayef211 Nayef211 marked this pull request as ready for review June 7, 2022 21:41
@Nayef211 Nayef211 requested a review from parmeet June 7, 2022 21:41
@Nayef211 Nayef211 mentioned this pull request Jun 7, 2022
9 tasks
@parmeet
Copy link
Contributor

parmeet commented Jun 7, 2022

  • add test to compare encoder inference on input with and without padding
  • remove bottom whitespace
  • remove unnecessary import
  • lint

not sure if we need this in the summary?

Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 14e4369 into pytorch:release/0.13 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants