-
Notifications
You must be signed in to change notification settings - Fork 812
Run Unittest on CircleCI #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
286ce68
to
fb21927
Compare
@cpuhrsch (CC @zhangguanheng66 cc @seemethere |
519272d
to
6d58702
Compare
Commented out binary build workflow. |
We can also turn off travis for tests covered by circleci. Looks like circle is also a lot faster. I know that some tests download vector files and such. Does circleci setup a cache for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mthrok. A quick question. Do you add nightly release here?
Sounds good, but I prefer doing it in a separate PR, unless you have a strong opinion in it.
In this configuration CCI caches the following things
Things happen after this, that includes PyTorch nightly installation, torch text installation, actual test run (and things downloaded while in test) are not cached. |
No, because I do not see existing scripts to be used for nightly release in |
@mthrok - Alright, sounds like we can merge this in its current stage, enable the C++ extension setup to uncomment the binary builds and then follow up with a) Disabling travis for tests covered by circleci What do you think? |
Sure, all of them sound reasonable and doable. Let's proceed with it. |
This PR adds unittest on CircleCI, by mostly copying configuration file from
torachaudio
.The test configuration is not 100% parity with the one in Travis.
--runslow
flag is not added yet.