Skip to content

Run Unittest on CircleCI #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2020
Merged

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Apr 28, 2020

This PR adds unittest on CircleCI, by mostly copying configuration file from torachaudio.

The test configuration is not 100% parity with the one in Travis. --runslow flag is not added yet.

@mthrok mthrok force-pushed the moto-circleci-unittest branch 2 times, most recently from 286ce68 to fb21927 Compare April 29, 2020 19:50
@mthrok
Copy link
Contributor Author

mthrok commented Apr 29, 2020

@cpuhrsch (CC @zhangguanheng66
I added unit test based on your CCI setting, and test is passing. (Yay
It's not completely same as the one running on Travis as --runslow flag is not added.
If we would like only one test to run slow tests, (like in Travis) we can do so.

cc @seemethere
BTW the support script required for binary build is not present in torchtext, so binary_XX jobs are failing.
What should we do?

@mthrok mthrok force-pushed the moto-circleci-unittest branch from 519272d to 6d58702 Compare April 29, 2020 20:33
@mthrok
Copy link
Contributor Author

mthrok commented Apr 29, 2020

Commented out binary build workflow.

@mthrok mthrok marked this pull request as ready for review April 29, 2020 20:44
@mthrok mthrok changed the title [DRAFT] Setup CircleCI Run Unittest on CircleCI Apr 29, 2020
@cpuhrsch
Copy link
Contributor

We can also turn off travis for tests covered by circleci. Looks like circle is also a lot faster. I know that some tests download vector files and such. Does circleci setup a cache for that?

Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mthrok. A quick question. Do you add nightly release here?

@mthrok
Copy link
Contributor Author

mthrok commented Apr 29, 2020

@cpuhrsch

We can also turn off travis for tests covered by circleci. Looks like circle is also a lot faster.

Sounds good, but I prefer doing it in a separate PR, unless you have a strong opinion in it.

I know that some tests download vector files and such. Does circleci setup a cache for that?

In this configuration CCI caches the following things

  • Miniconda (for conda command)
  • Conda environment (of different Python version), which contains dependencies listed in environment.yml.
    • These dependencies will be updated each time job is ran if a newer version is found.
  • Spacy English Dictionary.

Things happen after this, that includes PyTorch nightly installation, torch text installation, actual test run (and things downloaded while in test) are not cached.

@mthrok
Copy link
Contributor Author

mthrok commented Apr 29, 2020

@zhangguanheng66

thanks @mthrok. A quick question. Do you add nightly release here?

No, because I do not see existing scripts to be used for nightly release in torchtext. If you would like, I can copy and migrate the one from torchaudio.

@cpuhrsch
Copy link
Contributor

@mthrok - Alright, sounds like we can merge this in its current stage, enable the C++ extension setup to uncomment the binary builds and then follow up with

a) Disabling travis for tests covered by circleci
b) Caching vectors and other heavy objects specific to torchtext used during testing in circle
c) Setting up nightly builds

What do you think?

@mthrok
Copy link
Contributor Author

mthrok commented Apr 29, 2020

@mthrok - Alright, sounds like we can merge this in its current stage, enable the C++ extension setup to uncomment the binary builds and then follow up with

a) Disabling travis for tests covered by circleci
b) Caching vectors and other heavy objects specific to torchtext used during testing in circle
c) Setting up nightly builds

What do you think?

Sure, all of them sound reasonable and doable. Let's proceed with it.

@cpuhrsch cpuhrsch merged commit 62c5f38 into pytorch:master Apr 29, 2020
@mthrok mthrok deleted the moto-circleci-unittest branch May 1, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants