Install conda package from workspace #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
requested changes
May 28, 2020
seemethere
approved these changes
May 29, 2020
|
Thanks! |
|
Nightly build & smoke test worked ! https://app.circleci.com/pipelines/github/pytorch/text/345/workflows/a12396a9-9800-460c-96bf-738a6259fb66 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 14, 2020
When running smoke test, proper way to install conda package is to install from workspace, instead of installing from archive. Otherwise the dependencies are not properly installed conda/conda#1884 For this, we pass the whole `conda-bld` directory from conda package build job to upload job then smoke test job. `torchaudio` does not have a mandatory third-party python package dependency, so this was not an issue. See also pytorch/text#803
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 19, 2020
When running smoke test, proper way to install conda package is to install from workspace, instead of installing from archive. Otherwise the dependencies are not properly installed conda/conda#1884 For this, we pass the whole `conda-bld` directory from conda package build job to upload job then smoke test job. `torchaudio` does not have a mandatory third-party python package dependency, so this was not an issue. See also pytorch/text#803
mthrok
added a commit
to pytorch/audio
that referenced
this pull request
Aug 28, 2020
When running smoke test, proper way to install conda package is to install from workspace, instead of installing from archive. Otherwise the dependencies are not properly installed conda/conda#1884 For this, we pass the whole `conda-bld` directory from conda package build job to upload job then smoke test job. `torchaudio` does not have a mandatory third-party python package dependency, so this was not an issue. See also pytorch/text#803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running smoke test, proper way to install conda package is to install from workspace, instead of installing from archive. conda/conda#1884 Otherwise the dependencies are not properly installed https://app.circleci.com/pipelines/github/pytorch/text/340/workflows/1a453eb2-4480-4f49-babf-34e5230697f2/jobs/4401/steps .
For this, we pass the whole
conda-blddirectory from conda package build job to upload job then smoke test job.