Skip to content

Address quantization failures on devices #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Address quantization failures on devices #204

merged 6 commits into from
Apr 15, 2024

Conversation

mikekgfb
Copy link
Contributor

add device parameter for quantization a
place embedding quant table using device information

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 15, 2024
@mikekgfb mikekgfb requested a review from metascroy April 15, 2024 22:27
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@mikekgfb mikekgfb merged commit fbdd08c into main Apr 15, 2024
@mikekgfb mikekgfb deleted the cuda_testing branch April 16, 2024 05:37
malfet pushed a commit that referenced this pull request Jul 17, 2024
* add device for quantization, enable embedding quant with device

* typo

* fix filename weirdness

* enable mps embedding table runs

* import os for basename

* fix extraneous updates with group_size
malfet pushed a commit that referenced this pull request Jul 17, 2024
* add device for quantization, enable embedding quant with device

* typo

* fix filename weirdness

* enable mps embedding table runs

* import os for basename

* fix extraneous updates with group_size
malfet pushed a commit that referenced this pull request Jul 17, 2024
* add device for quantization, enable embedding quant with device

* typo

* fix filename weirdness

* enable mps embedding table runs

* import os for basename

* fix extraneous updates with group_size
malfet pushed a commit that referenced this pull request Jul 17, 2024
* add device for quantization, enable embedding quant with device

* typo

* fix filename weirdness

* enable mps embedding table runs

* import os for basename

* fix extraneous updates with group_size
malfet pushed a commit that referenced this pull request Jul 17, 2024
* add device for quantization, enable embedding quant with device

* typo

* fix filename weirdness

* enable mps embedding table runs

* import os for basename

* fix extraneous updates with group_size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants