Setting to use torch dynamo compiling path in eager #2045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57860075 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 28, 2024
Summary: 1/ Refactoring to use is_torchdynamo_compiling() from torchrec.pt2.checks instead of code duplication 2/ We have alternative path of logic is_torchdynamo_compiling(). Our tests are not testing it without compilation, so it is error prone to not catch some shape mismatch or etc. => We need a tool how to cover it with eager tests without compilation. => Introducing global setting to force using is_torchdynamo_compiling() path for eager for test coverage and debug. Enabling this path for test_pt2_multiprocess, that first eager iteration will be done on is_torchdynamo_compiling path. Differential Revision: D57860075
IvanKobzarev
force-pushed
the
export-D57860075
branch
from
0f167f7 to
d75d46b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57860075 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 28, 2024
Summary: 1/ Refactoring to use is_torchdynamo_compiling() from torchrec.pt2.checks instead of code duplication 2/ We have alternative path of logic is_torchdynamo_compiling(). Our tests are not testing it without compilation, so it is error prone to not catch some shape mismatch or etc. => We need a tool how to cover it with eager tests without compilation. => Introducing global setting to force using is_torchdynamo_compiling() path for eager for test coverage and debug. Enabling this path for test_pt2_multiprocess, that first eager iteration will be done on is_torchdynamo_compiling path. Differential Revision: D57860075
IvanKobzarev
force-pushed
the
export-D57860075
branch
from
d75d46b to
8094fe3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57860075 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 28, 2024
Summary: 1/ Refactoring to use is_torchdynamo_compiling() from torchrec.pt2.checks instead of code duplication 2/ We have alternative path of logic is_torchdynamo_compiling(). Our tests are not testing it without compilation, so it is error prone to not catch some shape mismatch or etc. => We need a tool how to cover it with eager tests without compilation. => Introducing global setting to force using is_torchdynamo_compiling() path for eager for test coverage and debug. Enabling this path for test_pt2_multiprocess, that first eager iteration will be done on is_torchdynamo_compiling path. Differential Revision: D57860075
IvanKobzarev
force-pushed
the
export-D57860075
branch
from
8094fe3 to
aee70fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57860075 |
Summary: Pull Request resolved: pytorch#2045 1/ Refactoring to use is_torchdynamo_compiling() from torchrec.pt2.checks instead of code duplication 2/ We have alternative path of logic is_torchdynamo_compiling(). Our tests are not testing it without compilation, so it is error prone to not catch some shape mismatch or etc. => We need a tool how to cover it with eager tests without compilation. => Introducing global setting to force using is_torchdynamo_compiling() path for eager for test coverage and debug. Enabling this path for test_pt2_multiprocess, that first eager iteration will be done on is_torchdynamo_compiling path. Reviewed By: PaulZhang12, gnahzg Differential Revision: D57860075
|
This pull request was exported from Phabricator. Differential Revision: D57860075 |
IvanKobzarev
force-pushed
the
export-D57860075
branch
from
aee70fd to
ddf7a38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
1/ Refactoring to use is_torchdynamo_compiling() from torchrec.pt2.checks instead of code duplication
2/ We have alternative path of logic is_torchdynamo_compiling(). Our tests are not testing it without compilation, so it is error prone to not catch some shape mismatch or etc. =>
We need a tool how to cover it with eager tests without compilation. =>
Introducing global setting to force using is_torchdynamo_compiling() path for eager for test coverage and debug.
Enabling this path for test_pt2_multiprocess, that first eager iteration will be done on is_torchdynamo_compiling path.
Differential Revision: D57860075