Pt2Pipeline input_transform just before model.compile #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58825466 |
|
This pull request was exported from Phabricator. Differential Revision: D58825466 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
Jun 20, 2024
Summary: Pull Request resolved: pytorch#2141 input_transformer is used to do pt2 hints like torch._dynamo.mark_dynamic/mark_unbacked that should happen exactly on the Tensor objects passed to model.compile Before that it was called before _to_device() that will produce new Tensor objects. Reviewed By: TroyGarden Differential Revision: D58825466
IvanKobzarev
force-pushed
the
export-D58825466
branch
from
330569e to
a144233
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58825466 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
Jun 20, 2024
Summary: Pull Request resolved: pytorch#2141 input_transformer is used to do pt2 hints like torch._dynamo.mark_dynamic/mark_unbacked that should happen exactly on the Tensor objects passed to model.compile Before that it was called before _to_device() that will produce new Tensor objects. Reviewed By: TroyGarden Differential Revision: D58825466
IvanKobzarev
force-pushed
the
export-D58825466
branch
from
a144233 to
ccea7f3
Compare
Summary: Pull Request resolved: pytorch#2141 input_transformer is used to do pt2 hints like torch._dynamo.mark_dynamic/mark_unbacked that should happen exactly on the Tensor objects passed to model.compile Before that it was called before _to_device() that will produce new Tensor objects. Reviewed By: TroyGarden Differential Revision: D58825466
|
This pull request was exported from Phabricator. Differential Revision: D58825466 |
IvanKobzarev
force-pushed
the
export-D58825466
branch
from
ccea7f3 to
a55226d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
input_transformer is used to do pt2 hints like torch._dynamo.mark_dynamic/mark_unbacked that should happen exactly on the Tensor objects passed to model.compile
Before that it was called before _to_device() that will produce new Tensor objects.
Differential Revision: D58825466