Add ability to specify pipelineable preproc modules to ignore during SDD model rewrite #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57944338 |
|
This pull request was exported from Phabricator. Differential Revision: D57944338 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 24, 2024
…SDD model rewrite (pytorch#2149) Summary: Pull Request resolved: pytorch#2149 Make torchrec automatically pipeline any modules that don't have trainable params during sparse data dist pipelining. tldr; with some traversal logic changes, TorchRec sparse data dist pipeline can support arbitrary input transformations at input dist stage as long as they are composed of either nn.Module calls or currently supported ops (mainly getattr and getitem) Differential Revision: D57944338
|
This pull request was exported from Phabricator. Differential Revision: D57944338 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 24, 2024
…SDD model rewrite (pytorch#2149) Summary: Pull Request resolved: pytorch#2149 Make torchrec automatically pipeline any modules that don't have trainable params during sparse data dist pipelining. tldr; with some traversal logic changes, TorchRec sparse data dist pipeline can support arbitrary input transformations at input dist stage as long as they are composed of either nn.Module calls or currently supported ops (mainly getattr and getitem) Differential Revision: D57944338
…SDD model rewrite (pytorch#2149) Summary: Pull Request resolved: pytorch#2149 Make torchrec automatically pipeline any modules that don't have trainable params during sparse data dist pipelining. tldr; with some traversal logic changes, TorchRec sparse data dist pipeline can support arbitrary input transformations at input dist stage as long as they are composed of either nn.Module calls or currently supported ops (mainly getattr and getitem) Reviewed By: dstaay-fb Differential Revision: D57944338
|
This pull request was exported from Phabricator. Differential Revision: D57944338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make torchrec automatically pipeline any modules that don't have trainable params during sparse data dist pipelining.
tldr; with some traversal logic changes, TorchRec sparse data dist pipeline can support arbitrary input transformations at input dist stage as long as they are composed of either nn.Module calls or currently supported ops (mainly getattr and getitem)
Differential Revision: D57944338